Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix port, remove port on doc URLs #4

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Conversation

VinneyJ
Copy link

@VinneyJ VinneyJ commented Jul 16, 2024

  1. change port from 8082 to 80
  2. changed domain from mediacloud.org to civicsignal.africa and removed 8082 port from in docs URLs,

Fixes #2

doc/api_2_0_spec/admin_api_2_0_spec.md Outdated Show resolved Hide resolved
doc/api_2_0_spec/api_2_0_spec.md Outdated Show resolved Hide resolved
doc/api_2_0_spec/api_2_0_spec.md Outdated Show resolved Hide resolved
@CodeForAfrica CodeForAfrica deleted a comment from thepsalmist Jul 16, 2024
Copy link

@DavidTheProgrammer DavidTheProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the typos

Copy link

@thepsalmist thepsalmist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/api_2_0_spec/admin_api_2_0_spec.md Outdated Show resolved Hide resolved
@VinneyJ VinneyJ requested a review from thepsalmist July 17, 2024 15:08
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 .. don't have full context so if @thepsalmist is happy with it, please proceed to merge


  1. Why is the API backend called app? Shouldn't it be api.civicsignal.africa instead of app.civicsignal.africa? app.hostname is usually a frontend/UI app e.g. https://app.gitbook.com, https://app.sendgrid.com/, etc.
  2. Lets fix or remove the GitHub actions (Not in this PR)
Screenshot 2024-07-18 at 11 06 42

doc/api_2_0_spec/admin_api_2_0_spec.md Outdated Show resolved Hide resolved
doc/api_2_0_spec/admin_api_2_0_spec.md Outdated Show resolved Hide resolved
@thepsalmist
Copy link

👍🏽 .. don't have full context so if @thepsalmist is happy with it, please proceed to merge

  1. Why is the API backend called app? Shouldn't it be api.civicsignal.africa instead of app.civicsignal.africa? app.hostname is usually a frontend/UI app e.g. https://app.gitbook.com, https://app.sendgrid.com/, etc.
  2. Lets fix or remove the GitHub actions (Not in this PR)
Screenshot 2024-07-18 at 11 06 42

I'm happy with making the domain changes to reflect this is an api and not app and make corresponding changes to the frontend applications

@VinneyJ
Copy link
Author

VinneyJ commented Jul 19, 2024

Cool on it.

Copy link

@DavidTheProgrammer DavidTheProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinneyJ VinneyJ merged commit 5f8a859 into cfa-main-1 Jul 19, 2024
1 of 2 checks passed
@VinneyJ VinneyJ deleted the port-readme-fix branch July 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants