-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix port, remove port on doc URLs #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 .. don't have full context so if @thepsalmist is happy with it, please proceed to merge
- Why is the API backend called
app
? Shouldn't it beapi.civicsignal.africa
instead ofapp.civicsignal.africa
?app.hostname
is usually a frontend/UI app e.g. https://app.gitbook.com, https://app.sendgrid.com/, etc. - Lets fix or remove the GitHub actions (Not in this PR)
I'm happy with making the domain changes to reflect this is an |
Cool on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2