-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pesacheck Meedan Bridge #549
Conversation
Add Dockerfile Test git image deployment on Dokku
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumps [boto3](https://github.com/boto/boto3) from 1.34.31 to 1.34.32. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.34.31...1.34.32) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [boto3](https://github.com/boto/boto3) from 1.34.32 to 1.34.33. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.34.32...1.34.33) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [boto3](https://github.com/boto/boto3) from 1.34.33 to 1.34.34. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.34.33...1.34.34) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [boto3](https://github.com/boto/boto3) from 1.34.34 to 1.34.35. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.34.34...1.34.35) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [boto3](https://github.com/boto/boto3) from 1.34.35 to 1.34.36. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.34.35...1.34.36) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.40.0 to 1.40.2. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@1.40.0...1.40.2) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Haven't gone through the code yet @koechkevin but linting throws errors: pants lint :: |
@kilemensi running pant lint, I get this error And also exists on main branch, not sure what causes this error. |
It does tell you what is wrong @koechkevin, no? 11:06:07.35 [ERROR] Completed: Lint with Hadolint - hadolint failed (exit code 1).
pesacheck_meedan_bridge/docker/Dockerfile:12 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
pesacheck_meedan_bridge/docker/Dockerfile:12 DL3009 info: Delete the apt-get lists after installing something
pesacheck_meedan_bridge/docker/Dockerfile:14 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
pesacheck_meedan_bridge/docker/Dockerfile:17 DL3009 info: Delete the apt-get lists after installing something
pesacheck_meedan_bridge/docker/Dockerfile:17 DL3015 info: Avoid additional packages by specifying `--no-install-recommends`
pesacheck_meedan_bridge/docker/Dockerfile:17 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
pesacheck_meedan_bridge/docker/Dockerfile:18 SC2016 info: Expressions don't expand in single quotes, use double quotes for that.
pesacheck_meedan_bridge/docker/Dockerfile:19 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
pesacheck_meedan_bridge/docker/Dockerfile:21 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
I think there should be just one instance of db loaded and locked (probably when main start). If main can not load db (e.g. in use), app exits.
main would then pass db to all function that need db access, etc.
- Set version to 0.1.0 - Remove uneeded files in gitignore - Move post to check to check_api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If language issue is fixed @koechkevin, lets deploy this as well.
Description
This PR adds Pesacheck Meedan Bridge script to upload fact checks as per this conversation.
Implementation approach is as outlined in #547.
This script is expected to be deployed as a docker image.
.env.example
.The variables are:
docker-compose up pesacheck_meedan_bridge --build -d
.pants run pesacheck_meedan_bridge/docker:pesacheck_meedan_bridge
./pex
daily.Development
.env
pesacheck_meedan_bridge/py/main.py
Fixes #547
Type of change
Please delete options that are not relevant.
Screenshots
Checklist: