Add Africa's talking adapter #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andela-mmakinde
force-pushed
the
add-africas-talking-adapter
branch
from
5bc08b6 to
b08a62e
Compare
| @@ -21,7 +21,7 @@ def get_nurses_from_nc_registry(query): | |||
| nurses = {'hits': [], 'total': 0} | |||
| try: | |||
| response = requests.get(url) | |||
| if 'No results' in response.content: | |||
| if b'No results' in response.content: | |||
There was a problem hiding this comment.
It turns the text in front of it into a bytes literal.
After updating the app to python3, it throws an error if 'No results' in response.content: TypeError: a bytes-like object is required, not 'str'
healthtools/settings.py
Outdated
| AFRICASTALKING = { | ||
| "SMS_AFRICASTALKING_USER": os.getenv("SMS_AFRICASTALKING_USER"), | ||
| "SMS_AFRICASTALKING_KEY": os.getenv("SMS_AFRICASTALKING_KEY"), | ||
| } |
There was a problem hiding this comment.
Similar to MTECH, some 3 things here:
- Let's have these as their own variables
- env variables must start with
HTOOLS_ - Use single quotes
healthtools/sms/__init__.py
Outdated
| @@ -18,7 +18,7 @@ def process_sms(args, adapter='mtech'): | |||
| # TODO: Track event SMS RECEIVED here | |||
|
|
|||
| result, doc_type = run_query(msg) | |||
|
|
|||
healthtools/views/sms.py
Outdated
| 'phoneNumber': request.values.get('from'), | ||
| 'message': request.values.get('text') | ||
| } | ||
|
|
There was a problem hiding this comment.
This would be done in the adapter itself similar to how we've achieved Twilio.
| python-3.6.2 |
There was a problem hiding this comment.
@andela-ookoro will add this changes in his PR that upgrades to python3
|
What's the |
…Tools.API into add-africas-talking-adapter with '#' will be ignored, and an empty message aborts the commit. with '#' will be ignored, and an empty message aborts the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Africa's talking sms adapter to the application.
Description of Task to be completed?
Add functionality for SMS to work with Africa's Talking. issue #56
How should this be manually tested?
<host>/sms/africastalkingon Africa's talking.Screenshots (if appropriate)
