Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap external calls with try-except #67

Merged

Conversation

andela-mmakinde
Copy link
Contributor

Solves #53

Any background context you want to provide?

  • None

Screenshots (if appropriate)
screen shot 2017-11-08 at 10 30 42 am
screen shot 2017-11-08 at 10 34 22 am

error_msg = "- MESSAGE: " + message['MESSAGE']
msg = "\n".join([error, source, error_msg])

log.error(msg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably able to be achieved with formatting? - https://docs.python.org/3/howto/logging-cookbook.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying it out.

@DavidLemayian
Copy link
Contributor

Also why did you move healthtools/manage.py → manage.py?

@andela-mmakinde
Copy link
Contributor Author

manage.py is meant to be in the root folder. Currently in the develop branch, the file is in the healthtools folder and the application doesn't run except the file is placed in the root.

@DavidLemayian DavidLemayian merged commit 09df6c0 into CodeForAfrica:develop Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants