Theme export and theme details flicker fix when duplicating and then canceling #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
changed the title
…nd then reappeared shortly after with the new name.
austincondiff
requested review from
0xWDG,
bombardier200,
FastestMolasses,
thecoolwinter,
tom-ludwig and
KaiTheRedNinja
austincondiff
changed the title
thecoolwinter
approved these changes
Nov 2, 2024
tom-ludwig
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user went to Theme settings and duplicated an existing theme then closed the sheet, there was a flicker of the duplicated theme as it faded out. That flicker is no longer there.
This PR also includes the following improvements
Related Issues
Checklist
Screenshots
Screen.Recording.2024-10-26.at.5.41.12.PM.mov