-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select multiple files in the project navigator #1906
Merged
austincondiff
merged 12 commits into
CodeEditApp:main
from
LeonardoLarranaga:select-multiple-files
Oct 23, 2024
Merged
Select multiple files in the project navigator #1906
austincondiff
merged 12 commits into
CodeEditApp:main
from
LeonardoLarranaga:select-multiple-files
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection where supported, open in finder, open in external editor.
…open in Finder, open in external editor.
Great work @LeonardoLarranaga! 🔥🔥🔥 Looking forward to reviewing this one |
austincondiff
requested review from
matthijseikelenboom,
lukepistrol,
MarcoCarnevali,
FastestMolasses,
thecoolwinter and
tom-ludwig
October 15, 2024 05:03
…nfirmation instead of one for every file.
austincondiff
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I've provided some text revisions, nothing big. If you'd like to change this, I can approve. Let me know if you have any other ideas.
CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager+FileManagement.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/ProjectNavigator/OutlineView/ProjectNavigatorMenuActions.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/ProjectNavigator/OutlineView/ProjectNavigatorMenuActions.swift
Outdated
Show resolved
Hide resolved
…rojectNavigatorMenuActions.swift Co-authored-by: Austin Condiff <[email protected]>
…leManagement.swift Co-authored-by: Austin Condiff <[email protected]>
…rojectNavigatorMenuActions.swift Co-authored-by: Austin Condiff <[email protected]>
austincondiff
previously approved these changes
Oct 18, 2024
@LeonardoLarranaga Please fix SwiftLint errors |
austincondiff
previously approved these changes
Oct 19, 2024
FastestMolasses
requested changes
Oct 23, 2024
CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager+FileManagement.swift
Outdated
Show resolved
Hide resolved
austincondiff
approved these changes
Oct 23, 2024
FastestMolasses
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the ability to select multiple files in the project navigator, having the ability to do the following batch actions:
Related Issues
Checklist
Screenshots
Screen.Recording.2024-10-14.at.21.20.44.mov
(idk what happened with that latex editor)