Fix search text disappearance on changing navigation item #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
requested review from
tom-ludwig,
austincondiff,
0xWDG,
matthijseikelenboom and
FastestMolasses
|
This looks good to me, before we merge could you update the comment on |
tom-ludwig
requested changes
Sep 21, 2024
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument+SearchState.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Ludwig <[email protected]>
0xWDG
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the disappearance of search text when using the Search Navigator, if you move away to another Navigator item (for example, Project Navigator).
Related Issues
Checklist
Screenshots
Screen.Recording.2024-09-20.at.6.37.04.PM.mov