Clean Up Child Processes #1885
Merged
Clean Up Child Processes #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
added
workspace
language server
thecoolwinter
requested review from
FastestMolasses,
austincondiff,
matthijseikelenboom,
0xWDG,
bombardier200 and
tom-ludwig
tom-ludwig
requested changes
Sep 21, 2024
Co-authored-by: Tom Ludwig <[email protected]>
tom-ludwig
previously approved these changes
Sep 24, 2024
0xWDG
previously approved these changes
Sep 24, 2024
FastestMolasses
requested changes
Sep 24, 2024
thecoolwinter
dismissed stale reviews from 0xWDG and tom-ludwig
via
d585370
FastestMolasses
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defers app termination until we've terminated all child processes (tasks and language servers). This ensures when CodeEdit is quit all related processes are terminated as well.
Related Issues
Checklist