Fix for symlinks bug #1840
Merged
Fix for symlinks bug #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #1839, correct? |
thecoolwinter
requested changes
Aug 21, 2024
There was a problem hiding this comment.
I've got a few suggestions for this change. I think it's a step in the right direction but just needs a little adjustment.
Also thank you for your time. I haven't had a ton of time to review PRs the last few weeks but I should be more responsive for a while here.
CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager+DirectoryEvents.swift
Outdated
Show resolved
Hide resolved
|
Where are we with this? Are we close? |
|
@austincondiff I've updated the PR so it ready for another round of reviews |
thecoolwinter
requested review from
austincondiff,
FastestMolasses and
tom-ludwig
tom-ludwig
requested changes
Sep 12, 2024
CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager+DirectoryEvents.swift
Show resolved
Hide resolved
tom-ludwig
approved these changes
Sep 14, 2024
austincondiff
approved these changes
Sep 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to CEWorkspaceFile and CEWorkspaceFileManager to support symlinks. It separates the id from the url on CEWorkspace file so there can be different files pointing to the same file url, similar to how Visual Studio Code handles symlinks.
Related Issues
closes #1839
Checklist
Screenshots