Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dark appearances from light appearances section (and in dark appearances) in themes settings #1374

Closed
wants to merge 1 commit into from

Conversation

luah5
Copy link
Member

@luah5 luah5 commented Jul 11, 2023

Description

this PR fixes a bug where dark appearances would appear in the light appearances section and light appearances would appear in the dark appearances section.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before:

shot 8 shot 9

After:

shot 11 shot 10

@austincondiff
Copy link
Collaborator

This is not a bug and is expected behavior. If you notice, in light mode the light themes are at the top and in dark mode the dark themes are at the top. Some people like having a dark theme in light mode. We don't want to assume users do not want this. Closing this PR.

@luah5 luah5 deleted the bugfix/themes-settings branch December 15, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Light appearances in dark appereances sections (& vice versa) in Themes Settings
2 participants