Add hotfix comments

CodeChain-io · Dec 21, 2020 · 42a3d6d · 42a3d6d
1 parent a20e149
commit 42a3d6d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/network/src/p2p/handler.rs b/network/src/p2p/handler.rs
@@ -516,6 +516,8 @@ impl IoHandler<Message> for Handler {
                         remote_node_id,
                         token
                     );
+                    // FIXME the if condition below is a hotfix.
+                    // `self.remote_node_ids_reverse.write().contains_key(&remote_node_id)` always should be false
                     if !self.remote_node_ids_reverse.write().contains_key(&remote_node_id) {
                         assert_eq!(
                             None,
@@ -548,6 +550,8 @@ impl IoHandler<Message> for Handler {
                         remote_node_id,
                         token
                     );
+                    // FIXME the if condition below is a hotfix.
+                    // `self.remote_node_ids_reverse.write().contains_key(&remote_node_id)` always should be false
                     if !self.remote_node_ids_reverse.write().contains_key(&remote_node_id) {
                         assert_eq!(
                             None,

diff --git a/sync/src/block/extension.rs b/sync/src/block/extension.rs
@@ -477,6 +477,8 @@ impl NetworkExtension<Event> for Extension {
         cinfo!(SYNC, "New peer detected #{}", id);
         self.send_status(id);
 
+        // FIXME the if condition below is a hotfix.
+        // `self.connected_nodes.contains(id)` always should be false
         if !self.connected_nodes.contains(id) {
             let t = self.connected_nodes.insert(*id);
             debug_assert!(t, "{} is already added to peer list", id);
@@ -488,6 +490,8 @@ impl NetworkExtension<Event> for Extension {
             request_id: None,
         };
 
+        // FIXME the if condition below is a hotfix.
+        // `self.requests.contains(id)` always should be false
         if !self.requests.contains_key(id) {
             let t = self.requests.insert(*id, Vec::new());
             debug_assert_eq!(None, t);