Add addressFilter parameter to the router of the tx-APIs #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addressFilter isn't doing anything in this patch yet. src/models/logic/transactions.ts should be changed in the future.
joojis
reviewed
Apr 15, 2019
| const LOG_FILTER = ["block", "tx", ...TYPES]; | ||
|
|
||
| // FIXME: | ||
| export const platformAddressSchema = Joi.string(); | ||
| // FIXME: PlatformAddress or AssetAddress | ||
| const address = Joi.string(); | ||
| const addressFilter = Joi.string().regex( | ||
| new RegExp(`^(${ADDRESS_TYPES.join("|")})(,(${ADDRESS_TYPES.join("|")}))*$`) | ||
| ); |
There was a problem hiding this comment.
Please make addressFilter invalidate if an address is not given.
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 67.45% 67.41% -0.04%
==========================================
Files 76 76
Lines 2074 2084 +10
Branches 289 293 +4
==========================================
+ Hits 1399 1405 +6
Misses 639 639
- Partials 36 40 +4
Continue to review full report at Codecov.
|
joojis
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressFilter isn't doing anything in this patch yet.
src/models/logic/transactions.ts should be changed in the future.