Use GPG'd netrc secrets when available #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
reviewed
Dec 25, 2016
| @@ -18,7 +18,7 @@ Gem::Specification.new do |spec| | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| spec.add_dependency 'nap', '>= 0.8', '< 2.0' | |||
| spec.add_dependency 'netrc', '0.7.8' | |||
| spec.add_dependency 'netrc', '0.10.0' | |||
There was a problem hiding this comment.
please use a ~> requirement for this again (it was exact because of a regression)
| @@ -141,6 +141,17 @@ def time_zone | |||
| out, = Executable.capture_command('/bin/date', %w(+%Z), :capture => :out) | |||
| out.strip | |||
| end | |||
|
|
|||
| def netrc_path | |||
There was a problem hiding this comment.
would this code do better being in the netrcgem itself?
There was a problem hiding this comment.
~Maybe. It's essentially just an override of Netrc.default_path
There was a problem hiding this comment.
it just doesn't feel like a feature that's specific to CocoaPods
There was a problem hiding this comment.
I tend to agree given that the code for handling GPG exists inside the upstream repo, just not for auto detecting it. I'll see if I can find any reasoning in commits/prs.
There was a problem hiding this comment.
this still hasn't been opened as an issue upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.