swift_package_product_dependency: override ascii_plist_annotation.
#932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a build plugin which is a Swift package, it's represented as a
`XCSwiftPackageProductDependency` object. The display name contains a "plugin:"
prefix so when it's serialized it's everywhere. The problem is that Xcode
removes this prefix and uses the package name in the keys of the serialized
objects and in refs to them (in the comments).
Below is an example before and after the change.
before (wrong):
```
/* Begin XCSwiftPackageProductDependency section */
19AA76E52A9F557900F1F6A1 /* plugin:SomePackageName */ = {
isa = XCSwiftPackageProductDependency;
productName = "plugin:SomePackageName";
};
```
after (correct):
```
/* Begin XCSwiftPackageProductDependency section */
19AA76E52A9F557900F1F6A1 /* SomePackageName */ = {
isa = XCSwiftPackageProductDependency;
productName = "plugin:SomePackageName";
};
```
|
The |
|
@dnkoutso Can you take a look please? Thank you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a build plugin which is a Swift package, it's represented as a
XCSwiftPackageProductDependencyobject. The display name contains a "plugin:" prefix so when it's serialized it's everywhere. The problem is that Xcode removes this prefix and uses the package name in the keys of the serialized objects and in refs to them.Below is an example before and after the change.
before (wrong):
after (correct):