Add clean shmems/queues/semaphores for sybase user #1213
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
This looks OK to me, but cleaning operations like this is a little bit tricky as it could make it more difficult for an administrator to figure out what the original problem was after multiple restarts... @oalbrigt Any opinion on this? If not for the reservation above, it seems fine. |
oalbrigt
reviewed
Sep 17, 2018
| @@ -437,6 +437,11 @@ ase_start() | |||
| then | |||
| rm -f $CONSOLE_LOG | |||
| fi | |||
|
|
|||
| ocf_log debug "Clean shmems/semaphores/queues for '$OCF_RESKEY_sybase_user'" | |||
There was a problem hiding this comment.
You should use the same indentation as in the rest of the code.
|
I guess this might make it harder to debug the initial issue, and if we include it maybe we should check that it the user isnt root before doing so. |
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents-pipeline/job/PR-1213/1/input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cleaner to prevent the error when resource failback.