targetcli 3.x support #1072
Open
targetcli 3.x support #1072
+20
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e target adjustments iSCSITarget add the ipv6 support that was removed from iSCSILogicalUnit, with conditional test
|
At first glance, these changes don't look backwards compatible to me, is that correct? Unfortunately, I don't know iSCSI well enough to be comfortable reviewing this. |
|
I believe the changes are compatible with targetcli 2 which is included in the current Linux distributions. Additionaly, I believe this PR resolves #1256. @patrickdk77, would you mind resolving the conflicts? I can do it if you don't... |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iSCSILogicalUnit fixups for lio-t to support targetcli 3.x, and remove target adjustments
iSCSITarget add the ipv6 support that was removed from iSCSILogicalUnit, with conditional test