High: VirtualDomain: Rename utilization parameters and reverse default #1051
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this change makes sense, or at least we should use the default placement-strategy instead of "balanced" in crmsh bootstrap. |
|
Can one of the admins verify this patch? |
|
add to whitelist |
Having the VirtualDomain agent set utilization limits by default is confusing and (in my opinion) not the correct choice. Someone setting the agent up for the first time would not look at the autoset parameters and consider utilization an advanced feature, and the resource wouldn't be able to start unless they had also set matching utilization limits on the nodes, or used the NodeUtilization agent. One option would be to just change the default value. It seemed more appropriate to rename the parameters, so that the change becomes more visible to anyone upgrading.
krig
force-pushed
the
virtualdomain-defaults
branch
from
1168983
to
c672f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the VirtualDomain agent set utilization limits by default
is confusing and (in my opinion) not the correct choice. Someone
setting the agent up for the first time would not look at the
autoset parameters and consider utilization an advanced feature,
and the resource wouldn't be able to start unless they had also
set matching utilization limits on the nodes, or used the
NodeUtilization agent.
One option would be to just change the default value. It seemed
more appropriate to rename the parameters, so that the change
becomes more visible to anyone upgrading.