Do not save chunks when auto saving is disabled #1280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is correct. Auto-save is the task of saving the world regularly whilst it's running so in the event of a crash, the server does not lose as much data. The proposed change turns auto-save into a property more like read-only or non-persistent world which should be a separate configuration field. |
|
Creating a separate setting for this could be good, it’a much easier to reset mini game maps when you can just unload and reload them |
|
Proper API included in #2175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #272
Currently Nukkit saves the chunks when the level is unloaded even if auto saving is disabled. This pr makes chunks to be never saved automatically if the auto saving is disabled (and if none of your plugins does the saving or you don't use the save-all command). The question is: Should disabling auto save only disable the auto save task or also the saving Nukkit does when levels are unloaded? Not saving chunks at all when the auto saving is disabled may be usefull on minigame servers where the worlds will be reseted after a match anyways.