fix: commodore class remap on latest spigot versions #1535
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
0utplay
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Spigot made a change to Commodore a few days ago (merged into paper yesterday) that made the
Commodore#convertnon-static. Therefore our current transformer for the class fails as it tries to return the slot 0 (which, when the method is static, is the first argument) which now is the Commodore instance.Modification
Check if the method being transformed is static and return slot 0 in that case, if the method is not static return slot 1. In both constellations the first argument of the convert method, the raw input class bytes, is returned.
Result
Latest Spigot/Paper Services no longer crash due to a bad stack frame.