Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non blocking output reader #1521

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from

Conversation

DasBabyPixel
Copy link
Contributor

@DasBabyPixel DasBabyPixel commented Oct 2, 2024

Motivation

Logging had some issues with blocking when a full line wasn't written in output.

Modification

Fixed those issues by implementing a custom readLine() which calls ready() before every read()

Result

Logging works with the new system (and very little delay, which is very nice, as opposed to 1 second polling alternative)

Other context

@0utplay or @GiantTreeLP please review this derklaro is fed up with this problem
Still based on the old logging to better highlight modifications. This is the reason why this is a conflict
As soon as this is reviewed I can rebase/merge and revert the revered new logging system to make this mergeable

@0utplay
Copy link
Member

0utplay commented Oct 3, 2024

Does this catch jvm crashes?

@DasBabyPixel
Copy link
Contributor Author

Does this catch jvm crashes?

Catches invalid jvm arguments
image

Also catches everything in a shutdown hook
image
(Used FileDescriptor, because logging frameworks don't print everything to console, probably some issue with async logging on shutdown)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants