Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase timeout for process termination #1422

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from

Commits on Jun 25, 2024

  1. chore: Increase timeout for process termination

    ### Motivation
    Current Java Edition Minecraft servers, especially those that are forks of the vanilla Minecraft server software, take some time to properly stop and save all resources, i.e. worlds, inventories and other state to disk.
    Prematurely terminating those processes leads to worlds not being saved at all, world corruption due to the interrupted save process and unloadable worlds. In addition this leads to lock files being left that don't belong to any process anymore.
    
    ### Modification
    Increase the timeout to 60 seconds. This gives servers more time to properly store all files and shutdown whilst still cleaning up servers that may have become stuck whilst shutting down.
    
    ### Result
    Server processes are now given more time to properly shutdown.
    GiantTreeLP authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ae80002 View commit details
    Browse the repository at this point in the history