Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webauthn tests p1 #230

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

cviecco
Copy link
Contributor

@cviecco cviecco commented May 24, 2024

enhance tests to prepare for migration

enhance logging
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 32.87%. Comparing base (f35df8b) to head (74ff576).
Report is 5 commits behind head on master.

Files Patch % Lines
cmd/keymasterd/2fa_webauthn.go 60.00% 4 Missing ⚠️
cmd/keymasterd/userProfile.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   32.09%   32.87%   +0.78%     
==========================================
  Files          75       75              
  Lines        9713     9733      +20     
==========================================
+ Hits         3117     3200      +83     
+ Misses       5957     5883      -74     
- Partials      639      650      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cviecco cviecco merged commit a40a44c into Cloud-Foundations:master Jun 12, 2024
9 checks passed
@cviecco cviecco deleted the enhance-webauthn-test-p1 branch June 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants