Fix client no retry on good token #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cviecco
commented
Jun 17, 2022
cviecco
commented
- The okta 2fa cope did not return an error message when no valid autneticators where available
- When both mfa AND token failed the client did not termiate on error conditins
rgooch
requested changes
Aug 18, 2022
| @@ -362,6 +362,7 @@ func setupCerts( | |||
|
|
|||
| } | |||
| } | |||
| logger.Debugf(1, "SetupCerts: authenticaiton Complete") | |||
There was a problem hiding this comment.
s/authenticaiton/authentication/
| } | ||
| if len(userResponse.Embedded.Factor) < 1 { | ||
| logger.Printf("oktaPushStartHandler: user %s does not have valid authenticators", authData.Username) | ||
| logger.Debugf(2, "oktaPushStartHandler: usedata for broken user%s is :%s", authData.Username, userResponse) |
| if err != nil { | ||
| return PushResponseRejected, err | ||
| } | ||
| if userResponse == nil { | ||
| return PushResponseRejected, nil | ||
| } | ||
| pa.logger.Debugf(2, "oktaAuthenticator: validsteUserPush: after getting userResponse=%+v", userResponse) |
|
Is this PR still needed? Review comments are still open. |
|
Closed with new revision reopened |
|
Changes in PR #240. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.