Don't check #present? of ActiveRecord objects because it's always true #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(or the variable is assigned nil and it's always false) While the rails maintainers argue about whether it's a good idea rails/rails#35059 I found this because out of curiosity I ran our test suite with ApplicationRecord#present? raising in our projects
|
it may also make sense to just look at the parent id not sure if we're going to make that lookup right afterwards anyway, but it is a thought |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(or the variable is assigned nil and it's always false)
While the rails maintainers decide whether it's a good idea
rails/rails#35059
I found this because out of curiosity I ran our test suite with
ApplicationRecord#present? raising in our projects