Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panel version cosistency when panel is created using the CLI #4987

Closed
wants to merge 4 commits into from

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Oct 30, 2024

This PR adds a functionality or fixes a bug.

This is a solution that will create mixed values for panel versions:

image

--> CLI panels with --version options will create panels with version as a Decimal128
--> Panels updated/created using the web portal will continue to have double (float) panel versions

I am not very fond of this solution but I gave it a try locally and it seems to work.

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. Test by creating panels using the cli and the panels web page. Make sure that the issues described in Panels do not handle sub-versions correctly #4986 are solved by this PR

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by

@northwestwitch northwestwitch changed the title Fix panel version Fix panel version cosistency when panel is created using the CLI Oct 30, 2024
@northwestwitch northwestwitch marked this pull request as draft October 30, 2024 15:07
Copy link

sonarcloud bot commented Oct 31, 2024

@northwestwitch
Copy link
Member Author

Closing this, as it's a solution I don't like

@northwestwitch northwestwitch deleted the fix_panel_version branch November 19, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panels do not handle sub-versions correctly
1 participant