Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds automatic ped_check fail #2066

Merged
merged 5 commits into from
Feb 21, 2024
Merged

adds automatic ped_check fail #2066

merged 5 commits into from
Feb 21, 2024

Conversation

jemten
Copy link
Collaborator

@jemten jemten commented Feb 20, 2024 •
edited
Loading

This PR adds | fixes:

  • Capture the results from the peddy's pedigree check and fail analysis in case of mismatch with given pedigree.
  • capture the results from peddy's sex check and automatically fail an analysis in the case of gender errors

How to test:

  • Automatic and continuous test suite

Expected outcome:

  • Installation, unit and integration test suite pass

Review:

  • Code review
  • Tests pass

This version is a:

  • MAJOR - when you make incompatible API changes. If applicable record manual test results in PR header
  • MINOR - when you add functionality in a backwards compatible manner. If applicable record manual test results in PR header
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@jemten jemten marked this pull request as ready for review February 20, 2024 10:23
@jemten jemten linked an issue Feb 20, 2024 that may be closed by this pull request
Fail analysis on error in Peddy #2059
Closed
@jemten jemten marked this pull request as draft February 20, 2024 13:53
@jemten
Copy link
Collaborator Author

jemten commented Feb 20, 2024

adding peddy sex check to this PR as well, see issue #2068

@jemten jemten linked an issue Feb 20, 2024 that may be closed by this pull request
Fail analysis for mismatch gender #2068
Closed
@jemten jemten marked this pull request as ready for review February 20, 2024 15:19
@jemten
Copy link
Collaborator Author

jemten commented Feb 20, 2024

ready for review @henrikstranneheim

peterpru
peterpru approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@peterpru peterpru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

lib/MIP/Qcc_regexp.pm Outdated Show resolved Hide resolved
@jemten @peterpru
Update lib/MIP/Qcc_regexp.pm
dc66fad 
Co-authored-by: Peter Pruisscher <[email protected]>
@jemten jemten merged commit 010a180 into develop Feb 21, 2024
9 checks passed
@jemten jemten deleted the peddy_check branch February 21, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpru peterpru peterpru approved these changes

@henrikstranneheim henrikstranneheim Awaiting requested review from henrikstranneheim henrikstranneheim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail analysis for mismatch gender Fail analysis on error in Peddy
2 participants
@jemten @peterpru