-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add msi analysis for TO workflow #1463
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1463 +/- ##
========================================
Coverage 99.48% 99.49%
========================================
Files 40 40
Lines 1932 1963 +31
========================================
+ Hits 1922 1953 +31
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I forget! We talked a bit about adding validation samples for this feature, like some sample with known high and low MSI which we can use to verify that the feature is working, and continues to keep working for future releases. I don't remember what you said about it, but did we have any such sample to add? I understand that actually verifying it for the tumor only validation cases is impossible without the PON, but it would be nice to make sure that we at least have a way to validate it in the validation of release 16 after the PON has been added. And for the WGS workflow where a PON exists, do we have a validation sample we could test? |
Also I'd love it if you could:
|
I added results from MSI analysis using MSI-PON for WGS-TO validation case. |
Description
Add MSI analysis for tumor-only workflow.
[PR description]
Added
Documentation
Tests
Feature Tests
Pipeline Integrity Tests
.hk
file)Clinical Genomics Stockholm
Documentation
Panel of Normal specific criteria
User Changes
Infrastructure Changes
Checklist
Important
Ensure that all checkboxes below are ticked before merging.
For Developers
For Reviewers
conditions where applicable, with satisfactory results.