Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make cadd snv optional #1304

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

mathiasbio
Copy link
Collaborator

This PR:

WIP. Missing issue at the moment.

Created this branch to make cadd_snv optional as the balsamic cache for hg38 did not have this file which prevented starting cases on hg38. But maybe I just have an incomplete cache...

Added: for new features.
Changed: for changes in existing functionality.
Deprecated: for soon-to-be removed features.
Removed: for now removed features.
Fixed: for any bug fixes.
Security: in case of vulnerabilities.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
BALSAMIC/commands/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/case.py 100.00% <100.00%> (+3.44%) ⬆️
BALSAMIC/commands/config/pon.py 100.00% <100.00%> (+4.87%) ⬆️
BALSAMIC/commands/init/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/options.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/deliver.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/status.py 100.00% <100.00%> (ø)
BALSAMIC/commands/run/analysis.py 100.00% <100.00%> (ø)
... and 20 more

📢 Thoughts on this report? Let us know!.

@ivadym
Copy link
Contributor

ivadym commented Oct 30, 2023

I'm building the cache for hg38, so we can test it. I don't think it's missing but let's see :)
/home/proj/stage/cancer/balsamic_cache/develop/hg38

The hg19 should be up to date (/home/proj/stage/cancer/balsamic_cache/develop/hg19). To use the develop cache just add a --cache-version develop flag to the config case

@khurrammaqbool
Copy link
Collaborator

@ivadym
Copy link
Contributor

ivadym commented Oct 31, 2023

It is generated. You can update your cache with the one we have in the develop/hg38 folder

{
    "cadd_snv": "variants/hg38.cadd_snv.tsv.gz",
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants