Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2079: Disable submit buttons and adds error notification #2096

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

h-tong
Copy link
Contributor

@h-tong h-tong commented Dec 16, 2019

Steps to Test #2079

  1. Create a scorable piece of individual, experimental, or case-control evidence in a GDM
  2. From the main gene-disease record page, click "View/Score" on your created piece of evidence
  3. Add a score and click "Save"
  4. Expect to see the "Save" button to disable and display a busy animation.

Steps to Test Error Notification

  1. Repeat steps 1 and 2 above.
  2. Go to your network tab in the Chrome dev tools and set the throttling from "Online" to "Offline" (to simulate an error occurring)
  3. Add a score and click "Save"
  4. Expect to see a red notification message show up in the top right corner of the page.

@markmandell markmandell self-requested a review January 14, 2020 18:45
Copy link
Contributor

@markmandell markmandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Tested all functionality and ran through our automated tests. Really like the addition of the notifications as well!

Copy link
Contributor

@shaungc-su shaungc-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the type button to submit for submitBusy! The error notification component looks handy, would be useful for other feature as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants