Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OkHttp 3.10 with JDK9+ support #45

Closed
wants to merge 5 commits into from
Closed

Upgrade to OkHttp 3.10 with JDK9+ support #45

wants to merge 5 commits into from

Conversation

aclowkey
Copy link

No description provided.

@judepereira
Copy link
Member

See #44 (comment).

@judepereira judepereira reopened this Jun 14, 2018
@judepereira judepereira self-requested a review June 14, 2018 13:15
@judepereira judepereira self-assigned this Jun 14, 2018
@judepereira judepereira changed the base branch from master to java9-okhttp June 17, 2018 09:47
@judepereira
Copy link
Member

@aclowkey Can you add in an integration test with a placeholder for the auth key and token? I'll set up these two as encrypted environment parameters in Travis CI - we'll be able to test this out in a better manner.

@aclowkey
Copy link
Author

I'm not familiar with the API. Do you mean use set up the client in this way:

APN_AUTH_KEY = ; // TODO Where will this come from? 
KEY_ID = ...
asyncClient = new ApnsClientBuilder().
                inAsynchronousMode().
                withApnsAuthKey(APN_AUTH_KEY).
                withKeyID(KEY_ID)

@judepereira
Copy link
Member

judepereira commented Jun 17, 2018 via email

@aclowkey aclowkey closed this by deleting the head repository Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants