Chapter 2 code review #3
Conversation
| @@ -1,20 +1,26 @@ | |||
| ### Code to exemplify Part 2 with Xiaoxia's query | |||
|
|
|||
| # Install and load packages ---- | |||
There was a problem hiding this comment.
I moved all package loading and installation to the beginning of the script. Packages are only installed if they are not present on the user's system.
| # Remove entries without a title | ||
| bib_data <- bib_data[bib_data$Title != "", ] | ||
|
|
There was a problem hiding this comment.
Hre I removed the entries without a title. That seems to have caused issues later in the BibEntry list.
| @@ -144,6 +150,9 @@ bib_data$Volume <- gsub("'", "", bib_data$Volume) | |||
| bib_data$Number <- gsub("'", "", bib_data$Number) | |||
| bib_data$Pages <- gsub("'", "", bib_data$Pages) | |||
|
|
|||
| # Remove entries without a title | |||
| bib_data <- bib_data[bib_data$Title != "", ] | |||
|
|
|||
| # Create a list of BibEntry objects | |||
| # (l got problems that l cannot extract title from those cases:title="'Inner-city is not the place for social housing' - State-led gentrification in Lodz" and '"Freeways without futures": Urban highway removal in the United States and Spain as socio-ecological fix?' ) | |||
There was a problem hiding this comment.
Does my addition above solve this issue or is this something else?
| # Remove entries without a title | ||
| combined_data <- combined_data[combined_data$Title != "", ] | ||
|
|
There was a problem hiding this comment.
Same as above, entries without title removed.
| #install.packages("PRISMAstatement") | ||
| library(PRISMAstatement) | ||
|
|
||
| # Section 4: build PRISMA figure (Xiaoxia) ---- |
There was a problem hiding this comment.
I think this section is unnecessarily long. It would be enough to show a full example with all/most customisation and refer the reader to the package documentation.
| # install_github("elizagrames/litsearchr", ref="main") | ||
| library(litsearchr) | ||
| library(igraph) | ||
| # Section 3: Suggest new keywords (Clementine) ---- |
There was a problem hiding this comment.
I so not have the data for this section, so I cannot run it.
| @@ -408,7 +416,7 @@ prisma(found = 750, | |||
| width = 200, height = 200, | |||
| dpi = 36) | |||
|
|
|||
| ## ----prismapdf, echo = TRUE, eval = FALSE-------------------------------- | |||
| ## Prismapdf | |||
There was a problem hiding this comment.
Can this section be removed?
|
@hadyyu, @valaneila, while talking to @ClementineCttn today I noticed that my review is on the wrong file, the R script, and it should be on the Rmd. I discussed the main points of my feeback with @ClementineCttn, but I will also check the Rmd file to see if I have any other suggestion. When I'm done I will leave an update here. |
I made some suggestions on the code for Chapter 2.
@bayi, I could not run Section 3 as I did not have the latest data for it. If you share it, I can also review that section as part of this PR.