Add glue for emergency setting overrides

ClearlyClaire · Jan 4, 2024 · 84f8cb9 · 84f8cb9
1 parent 5862895
commit 84f8cb9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/models/form/admin_settings.rb b/app/models/form/admin_settings.rb
@@ -91,7 +91,9 @@ class Form::AdminSettings
                      elsif OVERRIDEN_SETTINGS.include?(key)
                        public_send(OVERRIDEN_SETTINGS[key])
                      else
-                       Setting.public_send(key)
+                       # Avoid any of the emergency overrides by not doing
+                       # Setting.public_send(key)
+                       Setting[key.to_s]
                      end
 
       instance_variable_set(:"@#{key}", stored_value)

diff --git a/app/models/setting.rb b/app/models/setting.rb
@@ -57,5 +57,11 @@ def default_settings
 
       RailsSettings::Default.instance
     end
+
+    Emergency::SettingOverrideAction::ALLOWED_SETTINGS.each_key do |key|
+      define_method(key) do
+        Emergency::SettingOverrideAction.overridden_setting(key) || self[key]
+      end
+    end
   end
 end