New. Code. JSLint checking implemented. (#335)

* Upd. Code. ES-Lint code checking implemented. * Fix. Code. ES-Lint notices fixed for file `spbc-upload.js`. * Fix. Code. ES-Lint notices fixed for file `spbc-table.js`. * Fix. Code. ES-Lint notices fixed for file `spbc-upload.js` #2. * Fix. Code. ES-Lint notices auto fixed. * Fix. Code. ES-Lint notices fixed for file `spbc-settings_tab--traffic_control.js`. * Fix. Code. ES-Lint temporary ignoring unprocessed files.
CleanTalk · Apr 21, 2024 · 856011b · 856011b
1 parent 8a598ee
commit 856011b
Show file tree

Hide file tree

Showing 23 changed files with 3,292 additions and 3,060 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -0,0 +1,35 @@
+module.exports = {
+    env: {
+        browser: true,
+        es2021: true,
+    },
+    extends: 'google',
+    ignorePatterns: [
+        'js/src/lib/*.js',
+        'js/src/react/*.js',
+        'js/src/spbc-admin.js',
+        'js/src/spbc-common.js',
+        'js/src/spbc-cookie.js',
+        'js/src/spbc-dashboard-widget.js',
+        'js/src/spbc-modal.js',
+        'js/src/spbc-scanner-plugin.js',
+        'js/src/spbc-settings.js',
+        'js/src/spbc-settings_tab--backups.js',
+        'js/src/spbc-settings_tab--scanner.js',
+        'js/src/spbc-settings_tab--security_log.js',
+        'js/src/spbc-settings_tab--settings_general.js',
+        'js/src/spbc-settings_tab--summary.js',
+    ],
+    overrides: [],
+    parserOptions: {
+        ecmaVersion: 'latest',
+    },
+    rules: {
+        'indent': ['error', 4],
+        'max-len': ['error', {'code': 120}],
+        'prefer-const': 'off',
+    },
+    globals: {
+
+    },
+};
diff --git a/.github/workflows/eslint.yml b/.github/workflows/eslint.yml
@@ -0,0 +1,49 @@
+# .github/workflows/eslint.yml
+
+name: ESLint # name of the action (displayed in the github interface)
+
+on: # event list
+  push: # on push to each of these branches
+    branches:
+      - dev
+      - fix
+      - master
+  pull_request:
+    branches:
+      - dev
+      - master
+
+env: # environment variables (available in any part of the action)
+  NODE_VERSION: 16
+
+jobs: # list of things to do
+  linting:
+    name: ESLint # job name (unique id)
+    runs-on: ubuntu-latest # on which machine to run
+    steps: # list of steps
+      - name: Install NodeJS
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
+      - name: Code Checkout
+        uses: actions/checkout@v2
+
+      - name: Install Dependencies
+        run: npm i
+
+      - name: Code Linting
+        run: npm run eslint
+
+      - name: Telegram notify
+        if: failure()
+        uses: appleboy/telegram-action@master
+        with:
+          to: ${{ secrets.TELEGRAM_PLUGINS_TO }}
+          token: ${{ secrets.TELEGRAM_REVIEWER_TOKEN }}
+          message: |
+            Hi, <strong>${{ github.actor }}</strong>! Your commit for <strong>${{ github.repository }}</strong> 
+            contains 💯 the best solution but it have to be fixed!
+            <a href="${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}">Auto-Tests <strong>ESLint</strong></a> build failed ⛔!
+          format: html
+          disable_web_page_preview: true
diff --git a/inc/spbc-settings.php b/inc/spbc-settings.php
@@ -2173,8 +2173,8 @@ function spbc_field_traffic_control_logs__prepare_data(&$table)
 
         foreach ($table->rows as $row) {
             $ip = IP::reduceIPv6($row->ip_entry);
-            $allow_layout = '<a href="#" onclick="return spbc_tc__allow_ip(\'' . esc_attr($ip) . '\')" class="spbcGreen">' . esc_html__('Allow', 'security-malware-firewall') . '</a>';
-            $ban_layout = '<a href="#" onclick="return spbc_tc__ban_ip(\'' . esc_attr($ip) . '\')" class="spbc---red">' . esc_html__('Ban', 'security-malware-firewall') . '</a>';
+            $allow_layout = '<a href="#" onclick="return spbcTcAllowIp(\'' . esc_attr($ip) . '\')" class="spbcGreen">' . esc_html__('Allow', 'security-malware-firewall') . '</a>';
+            $ban_layout = '<a href="#" onclick="return spbcTcBanIp(\'' . esc_attr($ip) . '\')" class="spbc---red">' . esc_html__('Ban', 'security-malware-firewall') . '</a>';
             $ip = "<a href='https://cleantalk.org/blacklists/{$row->ip_entry}' target='_blank'>" . esc_html($ip) . '</a>'
                   . '<br>'
                   . $allow_layout . ' | ' . $ban_layout;
@@ -3344,7 +3344,7 @@ function spbc_list_table__get_args_by_type($table_type)
                     ),
                     'show_links' => array(
                         'name'    => 'Show links',
-                        'handler' => 'spbc_scanner__switch_table(this, "links");'
+                        'handler' => 'spbcScannerSwitchTable(this, "links");'
                     ),
                 ),
                 'order_by'          => array('spam_active' => 'desc'),
@@ -3752,7 +3752,7 @@ function spbc_list_table__get_args_by_type($table_type)
                     ),
                     'show_links' => array(
                         'name'    => 'Show links',
-                        'handler' => 'spbc_scanner__switch_table(this, "links");'
+                        'handler' => 'spbcScannerSwitchTable(this, "links");'
                     ),
                 ),
                 'order_by'          => array('spam_active' => 'desc'),

diff --git a/js/spbc-react-bundle.js b/js/spbc-react-bundle.js
diff --git a/js/spbc-table.min.js.map b/js/spbc-table.min.js.map
diff --git a/js/src/react/components/SpbctPage.js b/js/src/react/components/SpbctPage.js
@@ -26,7 +26,7 @@ class SpbctPage extends React.Component{
         jQuery('#spbc_button__sync').on('click', function(){
         jQuery('#spbc_button__sync_regular').hide();
         jQuery('#spbc_button__sync_action').show();
-            spbc_sendAJAXRequest(
+            spbcSendAJAXRequest(
                 {action: 'spbc_sync'},
                 {
                     timeout: 25000,