fix: Service not being update-able

ClarifiedSecurity · Feb 15, 2024 · 0ae107a · 0ae107a
1 parent 83d7acf
commit 0ae107a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/controllers/services_controller.rb b/app/controllers/services_controller.rb
@@ -34,7 +34,7 @@ def show
   end
 
   def update
-    if @service.update service_params
+    if authorize(@service).update(service_params)
       redirect_to [@service.exercise, @service], notice: 'Service was successfully updated.'
     else
       render :show, status: 400

diff --git a/app/models/concerns/vm_cache_buster.rb b/app/models/concerns/vm_cache_buster.rb
@@ -31,6 +31,6 @@ def get_service
         self
       else
         service
-      end.tap { |s| s.reload if s.persisted? }
+      end.dup.tap { |s| s.reload if s.persisted? }
     end
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -31,6 +31,6 @@ def get_service @@
             self
           else
             service
-          end.tap { |s| s.reload if s.persisted? }
+          end.dup.tap { |s| s.reload if s.persisted? }
         end
     end