Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with creating insecure channel for enterprise customers #17

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix issue with creating insecure channel for enterprise customers #17

wants to merge 3 commits into from

Conversation

johntorcivia
Copy link

  • Added CLARIFAI_GRPC_BASE override for insecure channel creation (was ignored)
  • Added CLARIFAI_GRPC_PORT for insecure channel creation (was hardcoded to 18080)
  • Updated readme with this information as well as how to change the CLARFAI_API_BASE for enterprise customers.

@johntorcivia johntorcivia requested a review from zeiler September 1, 2021 18:36
@johntorcivia johntorcivia marked this pull request as draft September 1, 2021 18:37
@johntorcivia
Copy link
Author

Still need to get the proper default GRPC port for insecure grpc; I don't think 18080 will work anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksander-clarifai aleksander-clarifai Awaiting requested review from aleksander-clarifai

@zeiler zeiler Awaiting requested review from zeiler

Assignees

@aleksander-clarifai aleksander-clarifai

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johntorcivia @aleksander-clarifai