949 missing leg in miovision_api.open_issues join
#950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielwol
changed the title
miovision_api.open_issues join
chmnata
reviewed
Jul 11, 2024
| @@ -26,18 +44,19 @@ JOIN miovision_api.intersections AS i USING (intersection_uid) | |||
| --find last week volume | |||
| LEFT JOIN miovision_api.volumes AS v | |||
| ON ar.intersection_uid = v.intersection_uid | |||
| --volume within the last 7 days and after AR started | |||
| AND v.datetime_bin >= ar.range_start | |||
There was a problem hiding this comment.
so for example if we run this today, and the range was add yesterday,
the sum volume for last_week_volume would be summing up only 1 day of data
There was a problem hiding this comment.
Yes, because we wouldn't want to know the volume from before range_start, which would either be zero, or non-zero from a time before the issue started. I could rename it/change it to average daily volume if you think that's better?
There was a problem hiding this comment.
yess, to reduce confusion if that ever happens
There was a problem hiding this comment.
Decided to explain it with a column comment and also in the check_open_anomalous_ranges airflow alert.
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
last_week_volumeto only look at dates within the AR + formatting that number with commasIssue(s) this solves:
What, in particular, needs to reviewed:
What needs to be done by a sysadmin after this PR is merged