Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1091 by properly filtering one-way streets #1092

Conversation

radumas
Copy link
Member

@radumas radumas commented Nov 1, 2024

The flow of traffic is opposite the drawn direction for one way streets that are -1

What this pull request accomplishes:

  • Fix a bug routing on one-way streets

Issue(s) this solves:

What, in particular, needs to reviewed:

  • Other examples worth testing? this isn't going to be perfect given the known issues with routing along the centreline

What needs to be done by a sysadmin after this PR is merged

  • Purge gis_core.routing_centreline_directional_DO_NOT_USE

The flow of traffic is opposite the drawn direction for one way streets that are -1
@radumas
Copy link
Member Author

radumas commented Nov 22, 2024

Now that I fluffed the sql, you'll have to replace the VIEW :meow_coy:

Copy link
Collaborator

@gabrielwol gabrielwol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
#1091 (comment)

@gabrielwol gabrielwol merged commit 74cc09f into master Nov 25, 2024
6 checks passed
radumas added a commit that referenced this pull request Dec 6, 2024
@radumas radumas mentioned this pull request Dec 6, 2024
radumas added a commit that referenced this pull request Dec 6, 2024
gabrielwol added a commit that referenced this pull request Dec 9, 2024
gabrielwol pushed a commit that referenced this pull request Dec 9, 2024
gabrielwol added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing on centreline returns wonky results on one way streets
2 participants