#1086 switch alerts to use custom operator #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielwol
approved these changes
Nov 19, 2024
dags/bluetooth_check_readers_temp.py
Outdated
| @@ -60,7 +60,7 @@ def blip_pipeline(): | |||
| pipeline_check = SQLCheckOperatorWithReturnValue( | |||
| task_id = 'pipeline_check', | |||
| conn_id = 'bt_bot', | |||
| sql = '''SELECT * | |||
| sql = '''SELECT (COUNT(*) > 0) AS "_check" | |||
There was a problem hiding this comment.
Similar to broken_readers sql below, can you please add a second column with a message?
Otherwise we get an alert without any details and we have to check the logs, ie.
temp_bluetooth_check_readers.pipeline_check (20241113T145010.485091+0000) FAILED. @Natalie @Gabe, please, check the logs
chmnata
deleted the
1086-temp_bluetooth_check_readers-dag-failing-silently_1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
Issue(s) this solves:
What, in particular, needs to reviewed:
What needs to be done by a sysadmin after this PR is merged
E.g.: these tables need to be migrated/created in the production schema.