Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add HOME ami chart #1666

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: add HOME ami chart #1666

merged 1 commit into from
Dec 4, 2024

Conversation

ColinBuyck
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses #1661

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This PR uses the ami import script (with some minor updates) to include the AMI chart in the issue.

How Can This Be Tested/Reviewed?

Reseed with cd backend/core and yarn db:reseed:detroit. Verify the chart is reflected when adding a unit group on the partners side and spot check some values in the db.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit 551dd70
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/67463b394320010008230ff7
😎 Deploy Preview https://deploy-preview-1666--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit 551dd70
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/67463b39c5d7f80008f83087
😎 Deploy Preview https://deploy-preview-1666--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck ColinBuyck marked this pull request as ready for review November 26, 2024 21:59
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇

Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ColinBuyck ColinBuyck merged commit 61cb989 into dev Dec 4, 2024
10 checks passed
@ColinBuyck ColinBuyck deleted the 1661/home-ami-chart branch December 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants