1640/resolve reset confirmation

[ColinBuyck]

Pull Request Template

Issue Overview

This PR addresses #1640

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

This is a more long-term fix to the password reset and account confirmation issues. By passing the token explicitly, the userControllerProfile() stops throwing an error. This PR also fixes an issue where the isUserConfirmationTokenValid was being called multiple times and falsely triggers the link expired modal.

How Can This Be Tested/Reviewed?

This can be tested by going through the password reset and new user confirmation on both the public and partner's site.

Checklist:

• My code follows the style guidelines of this project
• I have added QA notes to the issue with applicable URLs
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have run yarn generate:client and/or created a migration if I made backend changes that require them
• My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
• Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

• Read and understand the issue, and ensure the author has added QA notes
• Review the code itself from a style point of view
• Pull the changes down locally and test that the acceptance criteria is met
• Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
• Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

[netlify]

✅ Deploy Preview for detroit-partners-prod ready!

Name	Link
🔨 Latest commit	a0d9eed
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-partners-prod/deploys/6585ba081479f900084cc7d2
😎 Deploy Preview	https://deploy-preview-1650--detroit-partners-prod.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for detroit-public-staging ready!

Name	Link
🔨 Latest commit	a0d9eed
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-public-staging/deploys/6585ba0829618800088b9092
😎 Deploy Preview	https://deploy-preview-1650--detroit-public-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for detroit-partners-staging ready!

Name	Link
🔨 Latest commit	a0d9eed
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-partners-staging/deploys/6585ba0835958c000860679b
😎 Deploy Preview	https://deploy-preview-1650--detroit-partners-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.