Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force users to resign-in #1647

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: force users to resign-in #1647

merged 2 commits into from
Dec 19, 2023

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Dec 18, 2023

Pull Request Template

Issue Overview

This PR addresses #1640

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This error is coming from attempting to sign the user in after they've successfully reset their password. Resolving this issue is still in progress but this PR will force users to sign-in again and gain access to the partners portal. Given the severity of the issue and scale of users locked out, I think this change is appropriate to buy more time for a comprehensive fix.

Note: I included messaging to the sign-in page about successfully updating password but that alert box will not show success site alert messages (without a change to UIC) so I chose a notice style as opposed to having no communication.

How Can This Be Tested/Reviewed?

This can be tested by creating an account with an email you have access to, following the forgot password flow until you are successfully logged in.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for detroit-partners-prod ready!

Name Link
🔨 Latest commit 0b1ebda
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-prod/deploys/65810f490f0a5f00082c5312
😎 Deploy Preview https://deploy-preview-1647--detroit-partners-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for detroit-public-staging ready!

Name Link
🔨 Latest commit 0b1ebda
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-staging/deploys/65810f4953b6050008f52f73
😎 Deploy Preview https://deploy-preview-1647--detroit-public-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for detroit-partners-staging ready!

Name Link
🔨 Latest commit 0b1ebda
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-staging/deploys/65810f4929259e00098847b1
😎 Deploy Preview https://deploy-preview-1647--detroit-partners-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is a failing test and unfortunately for some reason the logs for it are unavailable. Maybe just try a re-run?

@ColinBuyck ColinBuyck merged commit 55b482a into main Dec 19, 2023
17 checks passed
@ColinBuyck ColinBuyck deleted the 1640/pw-reset-temp-fix branch December 19, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants