-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: force users to resign-in #1647
Conversation
✅ Deploy Preview for detroit-partners-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for detroit-public-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for detroit-partners-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There is a failing test and unfortunately for some reason the logs for it are unavailable. Maybe just try a re-run?
Pull Request Template
Issue Overview
This PR addresses #1640
Description
This error is coming from attempting to sign the user in after they've successfully reset their password. Resolving this issue is still in progress but this PR will force users to sign-in again and gain access to the partners portal. Given the severity of the issue and scale of users locked out, I think this change is appropriate to buy more time for a comprehensive fix.
Note: I included messaging to the sign-in page about successfully updating password but that alert box will not show success site alert messages (without a change to UIC) so I chose a notice style as opposed to having no communication.
How Can This Be Tested/Reviewed?
This can be tested by creating an account with an email you have access to, following the forgot password flow until you are successfully logged in.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.