feat: creating views for public and partner lists #1271
Conversation
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -63,13 +63,15 @@ views.partnerList = { | |||
| select: [ | |||
| "listings.id", | |||
| "listings.name", | |||
| "listings.applicationDueDate", | |||
| "property.id", | |||
| ...getBaseAddressSelect(["buildingAddress"]), | |||
There was a problem hiding this comment.
Do we need this address and the one on 73?
There was a problem hiding this comment.
on the partner site's listing grid we do display the address for the listing, so we do want to have that data
|
readd listing features |
There was a problem hiding this comment.
@YazeedLoonat ,
The publicListings view doesn't work for filtered or favorites since we want the listing to show as it does on the initial listing browse page, so I think we can get rid of that view and use base for those cases.
FYI, I fixed an unrelated issue I noticed with listing features not showing on the list pages.
|
Hey @seanmalbert I think we can keep the new views, I made a few updates if you want to take a peep but now filtered and favorite pages should functionally be the same as the main listings page lemme know what you think or if you still think we should switch to only updating the base view |
* feat: creating views for public and partner lists * fix: re-adding the features per sean * fix: fixes accessibilityFeaturesExist * fix: updates per sean * feat: update default listing view Co-authored-by: Sean Albert <[email protected]>
This address part 1 of that issue
Description
This creates 2 new listing views
one is specific to the public listings list, the other is specific to the partner listing list
How Can This Be Tested/Reviewed?
Head to https://detroit-public-dev.netlify.app/
verify that the listing data that is displayed on the listing list is what is expected
Head to https://detroit-partners-dev.netlify.app/sign-in
and do the same
for devs
I think this is easiest to test if you aim your local at prod or dev and pull up current prod and dev as well so you can quickly compare the result sets and what the front end looks like. They should look exactly the same
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.