Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CityOfDetroit/detroitmi#1112 #98

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fixes CityOfDetroit/detroitmi#1112 #98

merged 1 commit into from
Sep 26, 2023

Conversation

maxatdetroit
Copy link
Member

@maxatdetroit maxatdetroit commented Sep 25, 2023

Fixes CityofDetroit/detroitmi#1112

Using REMs (in conjunction with a statically set, small HTML element font-size) results in disproportionately small components on detroitmi.gov.

As discussed with @bankovic and @jedgar1mx , we're going to shift the UXDS to use EMs instead of REMs to allow the design system to have more independence and customization w.r.t. size.

This PR:

  • Changes all uses of REM to EM in compiled CSS
  • Creates a script to handle regenerating bootstrap and replacing uses of REM
  • Adds warnings about manually editing compiled bootstrap and instructions to use the compilation script

Testing

Run the script locally:

√ ~/projects/uxds % ./scripts/compile_bootstrap.sh
Compiling bootstrap SASS...
Replacing REMs with EMs...
Formatting output...
src/shared/themed-bootstrap.css 715ms

Tested visually by viewing button components in storybook:
fix-size-test

I'd like to test this on the detroitmi.gov site where the actual regression occurred, however my local instance is struggling to run due to memory constraints so I cannot test style changes locally. I considered trying to have the dev site use the style changes but that would require either packaging this change and bumping the version on dev or changing the dev site to use a local package both of which seemed overly cumbersome. @jedgar1mx would you be able to test this when creating the next package?

@maxatdetroit maxatdetroit added the bug Something isn't working label Sep 25, 2023
@maxatdetroit maxatdetroit self-assigned this Sep 25, 2023
@maxatdetroit maxatdetroit changed the title Fixes detroitmi/#1112 CityOfDetroit/detroitmi#1112 Sep 25, 2023
@maxatdetroit maxatdetroit changed the title CityOfDetroit/detroitmi#1112 Fixes CityOfDetroit/detroitmi#1112 Sep 25, 2023
@maxatdetroit maxatdetroit marked this pull request as ready for review September 26, 2023 13:18
Copy link
Member

@jedgar1mx jedgar1mx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes issues on detroitmi

@jedgar1mx jedgar1mx merged commit f818fa3 into dev Sep 26, 2023
@jedgar1mx jedgar1mx deleted the Fix.Sizing branch September 26, 2023 19:07
@jedgar1mx jedgar1mx linked an issue Sep 27, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size fix has been removed
2 participants