Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CityofDetroit/detroitmi#1112
Using REMs (in conjunction with a statically set, small HTML element font-size) results in disproportionately small components on detroitmi.gov.
As discussed with @bankovic and @jedgar1mx , we're going to shift the UXDS to use EMs instead of REMs to allow the design system to have more independence and customization w.r.t. size.
This PR:
REM
toEM
in compiled CSSREM
Testing
Run the script locally:
Tested visually by viewing button components in storybook:
I'd like to test this on the detroitmi.gov site where the actual regression occurred, however my local instance is struggling to run due to memory constraints so I cannot test style changes locally. I considered trying to have the dev site use the style changes but that would require either packaging this change and bumping the version on dev or changing the dev site to use a local package both of which seemed overly cumbersome. @jedgar1mx would you be able to test this when creating the next package?