Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion V2 #213

Merged
merged 3 commits into from
May 8, 2024
Merged

Accordion V2 #213

merged 3 commits into from
May 8, 2024

Conversation

maxatdetroit
Copy link
Member

Part of #202 & #205

This PR does the following:

  • Simplifies attribute naming conventions (removes data- prefix)
  • Migrates to using slots with basic markup
    • Removes the cod-accordion-header and cod-accordion-body components since they are unnecessary
    • Keeps the cod-accordion-item because it is necessary to set the id of nested accordion items programmatically and provide a container for styling
  • Temporarily removes support for list-style (example on dev storybook)
    • This will be added back in a separate PR. The implementation is so different that it'll be easier to review as a separate PR.
  • Permanently removes support for custom styling (example on dev storybook)

@maxatdetroit maxatdetroit added enhancement New feature or request cleanup labels May 6, 2024
@maxatdetroit maxatdetroit requested a review from jedgar1mx May 6, 2024 17:55
@maxatdetroit maxatdetroit self-assigned this May 6, 2024
@maxatdetroit maxatdetroit changed the base branch from dev to 2.0.0-alpha1 May 6, 2024 17:56
@jedgar1mx jedgar1mx merged commit 2cc922a into 2.0.0-alpha1 May 8, 2024
5 checks passed
@jedgar1mx jedgar1mx deleted the accordion.v2 branch May 8, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants