Fix dark navbar theming #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Changes in this PR
data-bs-themeusage in navbar since it has no effect on the navbar as currently writtennavbar-darkon navbar which correctly styles the toggle componentBootstrap 5.3 docs indicate that the
navbar-darkclass is deprecated in favor of dark theme (data-bs-theme=dark, however out-of-the-box the navbar toggle component is not controlled bydata-bs-theme=darkand still relies on the CSS variables overridden bynavbar-dark.Once we properly address #114 , we can re-add support for theming and customize bootstrap so that the theme properly customizes the navbar toggle as well.
Testing
Before PR
offcanvas-before.mov
toggle-before.mov
After PR
offcanvas-after.mov
toggle-after.mov