Fix lints in button component #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxatdetroit
force-pushed
the
fix.detroitmi1099.button
branch
from
8b4a89e to
603f546
Compare
maxatdetroit
force-pushed
the
fix.detroitmi1099.button
branch
from
603f546 to
af5f84e
Compare
jedgar1mx
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of CityofDetroit/detroitmi#1099
<cod-button/>componentNote: All the places where we are going from eqeq (==) to eqeqeq (===) are checking HTML attribute values using
getAttribute.getAttributealways returns null or empty string ("") if the value is not set. With this in mind, I went ahead and updated the places we use eqeq (==) to use either eqeqeq (===) comparison to string (since attributes are always string), or truthiness check.Testing
Test all the different stories and properties of the button component in storybook.