Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lints in icon element #108

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix lints in icon element #108

merged 1 commit into from
Nov 13, 2023

Conversation

maxatdetroit
Copy link
Member

Part of CityOfDetroit/detroitmi/issues/1099

This PR

  • Fixes ESLint errors in <cod-icon/>

Testing

Run render tests (which tests rendering icons):

$ yarn test-storybook
...
Test Suites: 30 passed, 30 total
Tests:       155 passed, 155 total
Snapshots:   0 total
Time:        10.648 s
Ran all test suites.

@maxatdetroit maxatdetroit self-assigned this Oct 13, 2023
@maxatdetroit maxatdetroit force-pushed the cleanup.detroitmi1099 branch from c095cb3 to 813811e Compare November 9, 2023 19:20
@maxatdetroit
Copy link
Member Author

@jedgar1mx merge conflicts are resolved here and ready for review.

@jedgar1mx jedgar1mx merged commit 862ac60 into dev Nov 13, 2023
3 checks passed
@jedgar1mx jedgar1mx deleted the cleanup.detroitmi1099 branch November 13, 2023 19:33
@maxatdetroit maxatdetroit linked an issue Nov 27, 2023 that may be closed by this pull request
Conform UXDS library to Prettier & ESLint standards #120
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedgar1mx jedgar1mx jedgar1mx approved these changes

@sreidthomas sreidthomas Awaiting requested review from sreidthomas

@SBBlee SBBlee Awaiting requested review from SBBlee

Assignees

@maxatdetroit maxatdetroit

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conform UXDS library to Prettier & ESLint standards
2 participants
@maxatdetroit @jedgar1mx