Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rounded corners in design system #106

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Remove rounded corners in design system #106

merged 1 commit into from
Oct 12, 2023

Conversation

maxatdetroit
Copy link
Member

@maxatdetroit maxatdetroit commented Oct 12, 2023

Changes Proposed in this PR

  • Remove rounded corners for all components by editing bootstrap variables and regenerating bootstrap css
$ ./scripts/compile_bootstrap.sh
Compiling bootstrap SASS...
Replacing REMs with EMs...
Formatting output...
src/shared/themed-bootstrap.css 361ms

Context

We currently have a mix of rounded and non-rounded corners throughout the design system with individual components (e.g. <cod-button/>) setting border radius to 0 to remove rounded corners.

Whether we use rounded corners or not will very based on the viewers opionion (there isn't a right answer), but being consistent is important to maintain some unity throughout the design system. The current detroitmi.gov site does not use rounded corners, so this PR moves to be consistent in non-rounded corners. If we decide we want to move to all rounded corners, we can do so but we'll have to go cleanup the places where individual components set border radius to 0 so we're taking the easier route for now.

Testing

View various, complex components before and after change:

Before

Screenshot 2023-10-12 at 12 26 45 PM
Screenshot 2023-10-12 at 12 26 34 PM
Screenshot 2023-10-12 at 12 26 06 PM

After

Screenshot 2023-10-12 at 12 25 42 PM
Screenshot 2023-10-12 at 12 24 55 PM
Screenshot 2023-10-12 at 12 22 29 PM

@maxatdetroit maxatdetroit added the bug Something isn't working label Oct 12, 2023
@maxatdetroit maxatdetroit self-assigned this Oct 12, 2023
@jedgar1mx jedgar1mx merged commit dc79cc6 into dev Oct 12, 2023
3 checks passed
@jedgar1mx jedgar1mx deleted the fix.border branch October 12, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants