Remove rounded corners in design system #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed in this PR
Context
We currently have a mix of rounded and non-rounded corners throughout the design system with individual components (e.g.
<cod-button/>
) setting border radius to 0 to remove rounded corners.Whether we use rounded corners or not will very based on the viewers opionion (there isn't a right answer), but being consistent is important to maintain some unity throughout the design system. The current detroitmi.gov site does not use rounded corners, so this PR moves to be consistent in non-rounded corners. If we decide we want to move to all rounded corners, we can do so but we'll have to go cleanup the places where individual components set border radius to 0 so we're taking the easier route for now.
Testing
View various, complex components before and after change:
Before
After