-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support action buttons in UXDS #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might cause some ADA flags since there is no valid text or description for the link.
Good catch @jedgar1mx , let me look at how we can better support ADA while still keeping the higher order component. |
@jedgar1mx this approach satisfies ARIA roles and other accessibility API metadata quite well. See details below and please let me know if I missed something related to a11y, and I'll go back to correct it. Details
Note: The icons used in the action button are missing titles, but that should be address in a separate PR (a fix put up to set |
2d2b405
to
30dc009
Compare
@jedgar1mx merge conflicts are resolved here and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CardIconContainer
a necessary component? It seems that we could just add the Icon on the CardHeader
or CardBody
as just part of the mark up.
Probably not necessary to have a separate component for |
b7916fb
to
4fae230
Compare
Part of #100
This PR
<clickable/>
that causes child elements to behave as a clickable elementAlternatives
Instead of introducing
Clickable
, we could have:cod-button
component. The main reason to avoid this approach is that some elements should not be considered buttons for accessibility (e.g. a screenreader should treat action buttons as links).<cod-clickable/>
and<cod-card/>
when building arpa buttons.Testing
Note: The action buttons are not equally sized in the test but can be by placing them in a card grid (like we do on the city homepage).