Fix remaining components

CityOfDetroit · Apr 25, 2024 · ecec3e2 · ecec3e2
1 parent cf1baa1
commit ecec3e2
Show file tree

Hide file tree

Showing 21 changed files with 25 additions and 37 deletions.
diff --git a/src/components/atoms/Alert/Alert.js b/src/components/atoms/Alert/Alert.js
@@ -20,7 +20,7 @@ export default class Alert extends HTMLElement {
     alertContent.id = 'alert-content';
     this.alert.appendChild(alertContent);
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         const nodeClasses = node.className.split(' ');

diff --git a/src/components/atoms/Breadcrumb/Breadcrumb.js b/src/components/atoms/Breadcrumb/Breadcrumb.js
@@ -22,7 +22,7 @@ export default class Container extends HTMLElement {
     this.nav = shadow.querySelector('nav');
     this.breadcrumb = shadow.querySelector('ol');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         const nodeClasses = node.className.split(' ');

diff --git a/src/components/atoms/CardBody/CardBody.js b/src/components/atoms/CardBody/CardBody.js
@@ -17,7 +17,7 @@ export default class CardBody extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.cardBody = document.createElement('div');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.cardBody.append(node);

diff --git a/src/components/atoms/CardFooter/CardFooter.js b/src/components/atoms/CardFooter/CardFooter.js
@@ -1,6 +1,6 @@
-import styles from '!!raw-loader!./CardFooter.css';
-import varStyles from '!!raw-loader!../../../shared/variables.css';
 import bootstrapStyles from '!!raw-loader!../../../shared/themed-bootstrap.css';
+import varStyles from '!!raw-loader!../../../shared/variables.css';
+import styles from '!!raw-loader!./CardFooter.css';
 
 const template = document.createElement('template');
 
@@ -17,7 +17,7 @@ export default class CardFooter extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.cardFooter = document.createElement('div');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.cardFooter.append(node);

diff --git a/src/components/atoms/CardHeader/CardHeader.js b/src/components/atoms/CardHeader/CardHeader.js
@@ -17,7 +17,7 @@ export default class CardHeader extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.cardHeader = document.createElement('div');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.cardHeader.append(node);

diff --git a/src/components/atoms/CardOverlay/CardOverlay.js b/src/components/atoms/CardOverlay/CardOverlay.js
@@ -17,7 +17,7 @@ export default class CardOverlay extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.cardOverlay = document.createElement('div');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.cardOverlay.append(node);

diff --git a/src/components/atoms/CarouselCaption/CarouselCaption.js b/src/components/atoms/CarouselCaption/CarouselCaption.js
@@ -17,7 +17,7 @@ export default class CarouselCaption extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.carouselCaption = document.createElement('div');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.carouselCaption.append(node);

diff --git a/src/components/atoms/CarouselItem/CarouselItem.js b/src/components/atoms/CarouselItem/CarouselItem.js
@@ -17,7 +17,7 @@ export default class CarouselItem extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.carouselItem = document.createElement('div');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.carouselItem.append(node);

diff --git a/src/components/atoms/Container/Container.js b/src/components/atoms/Container/Container.js
@@ -17,7 +17,7 @@ export default class Container extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.container = document.createElement('div');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.container.append(node);

diff --git a/src/components/atoms/DropdownMenu/DropdownMenu.js b/src/components/atoms/DropdownMenu/DropdownMenu.js
@@ -21,7 +21,7 @@ export default class DropdownMenu extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.dropdownMenu = document.createElement('ul');
 
-    this.shadowRoot.addEventListener('slotchange', (ev) => {
+    this.shadowRoot.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.dropdownMenu.append(node);
@@ -41,16 +41,12 @@ export default class DropdownMenu extends HTMLElement {
   }
 
   attributeChangedCallback(name, oldValue, newValue) {
-    console.log(newValue);
-
     const tempClasses = this.dropdownMenu.className.split(' ');
 
     const popValue = tempClasses.pop();
 
     popValue != 'show' ? tempClasses.push(popValue) : 0;
 
-    console.log(tempClasses);
-
     if (newValue == 'true') {
       tempClasses.push('show');
     }

diff --git a/src/components/atoms/FormCheck/FormCheck.js b/src/components/atoms/FormCheck/FormCheck.js
@@ -12,8 +12,7 @@ export default class FormCheck extends HTMLElement {
     // Always call super first in constructor
     super();
     // Create a shadow root
-
-    const shadow = this.attachShadow({ mode: 'open' });
+    this.attachShadow({ mode: 'open' });
     this.internals = this.attachInternals();
     this.container = document.createElement('div');
     this.formCheck = document.createElement('input');

diff --git a/src/components/atoms/FormControl/FormControl.js b/src/components/atoms/FormControl/FormControl.js
@@ -12,8 +12,7 @@ export default class FormControl extends HTMLElement {
     // Always call super first in constructor
     super();
     // Create a shadow root
-
-    const shadow = this.attachShadow({ mode: 'open' });
+    this.attachShadow({ mode: 'open' });
     this.internals = this.attachInternals();
     this.formControl = null;
     this.invalid = false;
@@ -29,7 +28,6 @@ export default class FormControl extends HTMLElement {
 
     switch (newValue) {
       case 'true':
-        console.log('invalid input');
         tempClasses.push('is-invalid');
         this.formControl.className = tempClasses.join(' ');
         break;

diff --git a/src/components/atoms/FormLabel/FormLabel.js b/src/components/atoms/FormLabel/FormLabel.js
@@ -6,8 +6,7 @@ export default class FormLabel extends HTMLElement {
     // Always call super first in constructor
     super();
     // Create a shadow root
-
-    const shadow = this.attachShadow({ mode: 'open' });
+    this.attachShadow({ mode: 'open' });
   }
 
   connectedCallback() {

diff --git a/src/components/atoms/FormSelect/FormSelect.js b/src/components/atoms/FormSelect/FormSelect.js
@@ -26,7 +26,7 @@ export default class FormSelect extends HTMLElement {
     // Create select and move options from slot to select
     this.select = shadow.querySelector('select');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const node = this.querySelector('option');
       node && this.select.append(node);
     });

diff --git a/src/components/atoms/Image/Image.js b/src/components/atoms/Image/Image.js
@@ -19,7 +19,7 @@ export default class Image extends HTMLElement {
     // Create select and move options from slot to select
     this.picture = shadow.querySelector('picture');
 
-    shadow.addEventListener('slotchange', (ev) => {
+    shadow.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.picture.append(node);

diff --git a/src/components/atoms/ListGroupItem/ListGroupItem.js b/src/components/atoms/ListGroupItem/ListGroupItem.js
@@ -48,8 +48,6 @@ export default class ListGroupItem extends HTMLElement {
         break;
 
       case 'data-order-index':
-        console.log(newValue);
-
         if (newValue != null) {
           this.listGroupItem.innerHTML = `${newValue}. ${this.listGroupItem.innerHTML}`;
 
@@ -111,7 +109,7 @@ export default class ListGroupItem extends HTMLElement {
     ].join(' ');
 
     if (!this.shadowRoot.querySelector(tag)) {
-      this.shadowRoot.addEventListener('slotchange', (ev) => {
+      this.shadowRoot.addEventListener('slotchange', () => {
         const tempElements = Array.from(this.children);
         tempElements.forEach((node) => {
           this.listGroupItem.append(node);

diff --git a/src/components/atoms/Loader/Loader.js b/src/components/atoms/Loader/Loader.js
@@ -5,8 +5,7 @@ export default class Loader extends HTMLElement {
     // Always call super first in constructor
     super();
     // Create a shadow root
-
-    const shadow = this.attachShadow({ mode: 'open' });
+    this.attachShadow({ mode: 'open' });
   }
 
   connectedCallback() {

diff --git a/src/components/atoms/ModalBody/ModalBody.js b/src/components/atoms/ModalBody/ModalBody.js
@@ -17,7 +17,7 @@ export default class ModalBody extends HTMLElement {
     shadow.appendChild(template.content.cloneNode(true));
     this.body = document.createElement('div');
 
-    this.shadowRoot.addEventListener('slotchange', (ev) => {
+    this.shadowRoot.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.body.append(node);

diff --git a/src/components/atoms/ModalFooter/ModalFooter.js b/src/components/atoms/ModalFooter/ModalFooter.js
@@ -18,7 +18,7 @@ export default class ModalFooter extends HTMLElement {
     this.modalFooter = document.createElement('div');
     this.closeBtn = document.createElement('cod-button');
 
-    this.shadowRoot.addEventListener('slotchange', (ev) => {
+    this.shadowRoot.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.modalFooter.appendChild(node);
@@ -69,7 +69,7 @@ export default class ModalFooter extends HTMLElement {
     this.removeEventListener('click', this._onClick.bind(this));
   }
 
-  _onClick(e) {
+  _onClick() {
     this.getRootNode()
       .host.getRootNode()
       .host.setAttribute('data-show', 'false');

diff --git a/src/components/atoms/ModalHeader/ModalHeader.js b/src/components/atoms/ModalHeader/ModalHeader.js
@@ -19,7 +19,7 @@ export default class ModalHeader extends HTMLElement {
     this.modalTitle = document.createElement('div');
     this.closeBtn = document.createElement('cod-button');
 
-    this.shadowRoot.addEventListener('slotchange', (ev) => {
+    this.shadowRoot.addEventListener('slotchange', () => {
       const tempElements = Array.from(this.children);
       tempElements.forEach((node) => {
         this.modalTitle.appendChild(node);
@@ -75,7 +75,7 @@ export default class ModalHeader extends HTMLElement {
     this.removeEventListener('click', this._onClick.bind(this));
   }
 
-  _onClick(e) {
+  _onClick() {
     this.getRootNode()
       .host.getRootNode()
       .host.setAttribute('data-show', 'false');

diff --git a/src/components/atoms/Progress/Progress.js b/src/components/atoms/Progress/Progress.js
@@ -6,8 +6,7 @@ export default class Progress extends HTMLElement {
     // Always call super first in constructor
     super();
     // Create a shadow root
-
-    const shadow = this.attachShadow({ mode: 'open' });
+    this.attachShadow({ mode: 'open' });
   }
 
   connectedCallback() {